Ticket #172 (feature request)

Sean: see attachment.

Sample invocation:

>>> import ows
>>> ex=ows.OWSExceptionReport("1.0.0", "en-CA", "InvalidParameterValue", "request", "oops!")
>>> ex.toxml()
'<?xml version="1.0" ?><ExceptionReport xmlns="http://www.opengis.net/ows/1.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.0.0" xsi:schemaLocation="http://www.opengis.net/ows/1.1 http://schemas.opengis.net/ows/1.1.0/owsExceptionReport.xsd"><Exception exceptionCode="InvalidParameterValue" locator="request"><ExceptionText>oops!</ExceptionText></Exception></ExceptionReport>'
>>> 

FYI as part of the integration, we will update the wcs 1.1 classes to leverage ows.py

Tom, we have some suggestions: handle namespacing with a function e.g. (http://proj.badc.rl.ac.uk/csml/browser/Python/trunk/csml/parser.py)

nsGML = 'http://www.opengis.net/gml'

def GML(tag):

return "{"+nsGML+"}"+tag

Consolidate attribute parsing blocks using a function or method.

Move OWS exception class to a separate module. It would be the first server side class in the package. We're interested in how you are using it.

Dominic: comments:

• • I've defined a util.py which has a nspath function. The path and namespace are passed to this function, which returns the proper namespace-aware path. Note that this works only for XML paths which use the same namespace throughout. For those that don't, I've left the existing fuctionality. See attached util.py and updated ows.py. If this suffices, I will update sos.py and filter.py in the other tickets
  • Can you elaborate on attribute parsing block functions (example)?
  • I put the server side class in there because I saw it in wms.py, hence going along. I would say take it out if we have no direct use for it (in both ows.py and wms.py)

Re the server side class: WMSError - I can't see that this is used anywhere in wms.py I agree with taking it out if it's not used.

Re Attribute parsing blocks:

This pattern is repeated frequently:

if val is not None:

self.contact.city = val.text else: self.contact.city = None

The suggestion meant you could consolidate this pattern into a function such as: setValue('self.contact.city', val)

Re nspath, I think that is a good thing to have in the util module. We need to do some harmonization but I think building a common util module is a good start!

Ok, done:

• • removed Server Exception class
  • updated util.py (new attached) with testXMLValue convenience function
  • updated ows.py (new attached) to use util.testXMLValue()

Next steps?